SDK-344 - SDK should support including spa from a maven artifact #303
Conversation
| spa.artifactId=openmrs-frontend-zl | ||
| spa.groupId=org.pih.openmrs | ||
| spa.version=1.3.0 | ||
| spa.include=openmrs-frontend-zl-1.3.0 |
There was a problem hiding this comment.
This is probably obvious and I'm just missing it, but why do we have to limit to "openmrs-frontend-zl-1.3.0"
There was a problem hiding this comment.
This is a hack/feature I had to add in, which I had originally hoped to avoid, because when we build our frontend zips we don't just include the files but we include them in a nested directory with this name. So this is how I am providing an option to say "don't just unpack the entire zip as-is, but unpack it and copy in the contents of this subdirectory within the zip".
|
Not essential to this, but the unpack goal we’re using has an |
Interesting - I'll look to see if I can switch this to use that, thanks @ibacher . If nothing else, it gives me more confidence in my choice of property name, which I struggled over. Maybe I'll update it from |
|
So, I tried out using the includes property of the unpack goal, and it did not work as I wanted. As far as I can tell, there isn't a way to tell it to include the contents of a subdirectory but not the subdirectory itself. So I kept my initial implementation. I did change the property name from |
see https://openmrs.atlassian.net/browse/SDK-344